-
Notifications
You must be signed in to change notification settings - Fork 4
MICRO: Chore/debug assert warnings #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aca6067
to
f98d81d
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #131 +/- ##
=======================================
Coverage ? 51.75%
=======================================
Files ? 147
Lines ? 24714
Branches ? 0
=======================================
Hits ? 12791
Misses ? 11923
Partials ? 0
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not MICRO nor a chore
PR.
It has a lot of stuff from #128.
Maybe we should wait that one to be merged then rebase?
I know :) |
My bad I've forgot to check the "note to reviewers" section. |
f98d81d
to
62e779e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 62e779e
62e779e
to
c8482ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK c8482ec
But let's wait for @Rajil1213's review as well.
This doesn't need two reviews. I'm merging. |
Description
This PR adds debug assertions to the warning logs in the CSM. This is helpful if we ever want to run the bridge in strict mode to get out ahead of potential issues, even if we think we know how to handle them.
Type of Change
Notes to Reviewers
This is based on #128 and so it should be reviewed after. I briefly tried to rebase it directly onto main but it's not worth it.
Checklist
Related Issues