Skip to content

Eliminate MuSig2 Session Errors #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ProofOfKeags
Copy link
Contributor

Description

This PR aims to eliminate the errors we are seeing in the duty-tracker that seem to be resulting from not being able to find a musig session.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 54.15%. Comparing base (00b9b63) to head (3c2a45d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/duty-tracker/src/contract_manager.rs 0.00% 12 Missing ⚠️
crates/duty-tracker/src/s2_session_manager.rs 0.00% 5 Missing ⚠️
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   54.16%   54.15%   -0.02%     
==========================================
  Files         145      145              
  Lines       23697    23702       +5     
==========================================
  Hits        12836    12836              
- Misses      10861    10866       +5     
Files with missing lines Coverage Δ
crates/duty-tracker/src/s2_session_manager.rs 0.00% <0.00%> (ø)
crates/duty-tracker/src/contract_manager.rs 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@storopoli storopoli changed the title Eliminate Musg2 Session Errors Eliminate Musig2 Session Errors May 7, 2025
@storopoli storopoli changed the title Eliminate Musig2 Session Errors Eliminate MuSig2 Session Errors May 7, 2025
Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3c2a45d

Nice catch with the ouroboros before new blocks.

@ProofOfKeags ProofOfKeags added bugfix Something isn't working P3 - Experimental labels May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something isn't working P3 - Experimental
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants