Skip to content

fix(p2p): more fault-tolerant establish_connections #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

storopoli
Copy link
Member

Description

WIP trying to make more fault-tolerant establish_connections.
See also alpenlabs/strata-p2p#62.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 18.75000% with 39 lines in your changes missing coverage. Please review.

Project coverage is 53.36%. Comparing base (01a19e6) to head (a00f9e8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/p2p-service/src/bootstrap.rs 0.00% 32 Missing ⚠️
bin/alpen-bridge/src/mode/operator.rs 0.00% 6 Missing ⚠️
crates/duty-tracker/src/contract_manager.rs 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   53.43%   53.36%   -0.07%     
==========================================
  Files         145      145              
  Lines       24153    24201      +48     
==========================================
+ Hits        12905    12914       +9     
- Misses      11248    11287      +39     
Files with missing lines Coverage Δ
bin/alpen-bridge/src/config.rs 94.73% <ø> (ø)
crates/p2p-service/src/config.rs 100.00% <100.00%> (ø)
crates/duty-tracker/src/contract_manager.rs 0.00% <0.00%> (ø)
bin/alpen-bridge/src/mode/operator.rs 0.00% <0.00%> (ø)
crates/p2p-service/src/bootstrap.rs 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@storopoli storopoli force-pushed the fix/better-retries branch 2 times, most recently from 3068124 to 7bb1245 Compare May 9, 2025 21:24
@storopoli

This comment was marked as outdated.

@storopoli storopoli force-pushed the fix/better-retries branch 3 times, most recently from 87639d5 to 20e4b18 Compare May 12, 2025 15:42
@storopoli storopoli force-pushed the fix/better-retries branch from 20e4b18 to a00f9e8 Compare May 12, 2025 16:05
@storopoli
Copy link
Member Author

Closing in favor of #140

@storopoli storopoli closed this May 12, 2025
@storopoli storopoli deleted the fix/better-retries branch May 12, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant