Skip to content

Conversation

@storopoli
Copy link
Member

Description

Tweaks some gossipsub configs from the default value to reduce message duplication across the P2P network.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@storopoli storopoli requested a review from Rajil1213 April 28, 2025 13:51
@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2025

The latest Buf updates on your PR. Results from workflow Lint / proto (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMay 12, 2025, 9:13 PM

@codecov
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (8cb5707) to head (37b5978).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   82.53%   82.62%   +0.09%     
==========================================
  Files          13       13              
  Lines        1506     1514       +8     
==========================================
+ Hits         1243     1251       +8     
  Misses        263      263              
Files with missing lines Coverage Δ
crates/p2p/src/swarm/behavior.rs 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@storopoli storopoli marked this pull request as draft May 12, 2025 21:09
@storopoli storopoli marked this pull request as ready for review May 12, 2025 21:14
@storopoli storopoli self-assigned this May 12, 2025
@storopoli storopoli removed the request for review from Rajil1213 May 12, 2025 21:15
@storopoli storopoli marked this pull request as draft May 12, 2025 21:15
@storopoli
Copy link
Member Author

Closing this in favor of the V2 revamp.

@storopoli storopoli closed this Jun 12, 2025
@storopoli storopoli deleted the tweak-configs branch June 12, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants