Skip to content

Conversation

@prajwolrg
Copy link
Collaborator

@prajwolrg prajwolrg commented Jan 23, 2025

Description

This PR refactors the Groth16 proof handling to improve consistency and simplify the interface. Instead of passing the proof and public values separately, they are now bundled together for better cohesion.

Additionally, the Fibonacci prover has been set to use Groth16 as the default. This change ensures that the corresponding proof verification logic can be thoroughly tested with the default configuration.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@prajwolrg prajwolrg force-pushed the refactor/handle-groth16-proof branch from ddc7ef3 to 57d4a69 Compare January 23, 2025 19:23
@prajwolrg prajwolrg changed the title Properly handle groth16 proof Refactor Groth16 Proof Handling Jan 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025

Commit: 26e461b

SP1 Performance Test Results

program cycles success
fibonacci 4,983
sha2 8,158
schnorr 4,457,775

RISC0 Performance Test Results

program cycles success
fibonacci 2,544
sha2 8,279
schnorr 5,014,149

@prajwolrg prajwolrg marked this pull request as ready for review January 24, 2025 07:15
@MdTeach MdTeach added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit 7db07d0 Jan 24, 2025
11 checks passed
@prajwolrg prajwolrg deleted the refactor/handle-groth16-proof branch January 26, 2025 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants