Skip to content

Conversation

@prajwolrg
Copy link
Collaborator

@prajwolrg prajwolrg commented Feb 24, 2025

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

I accidentally pushed it directly to main instead of a branch when I was trying to rebase things after the last PR. See https://github.com/alpenlabs/zkaleido/compare/refactor/traits..feat/remote-prover for actual changes this PR was meant to cover.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@prajwolrg prajwolrg marked this pull request as ready for review February 24, 2025 06:24
@github-actions
Copy link
Contributor

Commit: 8168962

SP1 Execution Results

program cycles success
fibonacci 1,187
sha2_chain 8,034
schnorr_sig_verify 4,457,633

RISC0 Execution Results

program cycles success
fibonacci 2,541
sha2_chain 8,274
schnorr_sig_verify 5,014,158

@MdTeach MdTeach added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit 84379bc Feb 24, 2025
11 checks passed
@prajwolrg prajwolrg deleted the feat/remote-prover branch March 7, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants