Skip to content

Full clone support for both x86_64 and RISC-V #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GlassOfWhiskey merged 144 commits into from
Jul 22, 2025
Merged

Full clone support for both x86_64 and RISC-V #2

GlassOfWhiskey merged 144 commits into from
Jul 22, 2025

Conversation

@SilenceDesigner
Copy link
Collaborator

@SilenceDesigner SilenceDesigner commented Jul 7, 2025

  • Full clone interception support: intercept_routine_post_clone is now executed for clone system calls which share stack space as well
  • Building: Capstone 5.0.6 is now automatically compiled from source and linked to syscall_intercept to avoid linking and inclusion issues

Ottavio Monticelli and others added 30 commits April 30, 2024 02:51
major changes due to difference between RISC-V and x64. Updated versi…
b46d41c 
…ons of intercept.c and assembly files still need to be pushed. A lot of clean up to do
Trampoline doesn't prematurely clobber used registers anymore
402a337
sp value changes now keep it 16-byte boundary aligned
3efb0e3
Now instruction following ecall must not use ra as operand to be able…
ce40f2f 
… to be patched
context and its references are now coherent with RISC-V and stack lay…
0a206ab 
…out in intercept_wrapper
Assembly files now follow the correct logic. Clone should now be hand…
1ca3f27 
…led as intended
pattern1 work in progress
d1cb7a8
code cleanup
07af378
pointer small fix
b5499cc
small pointer fix and added prototype of a function
8b4ce8d
small fix, code cleanup and disabled CMake PERFORM_STYLE_CHECKS and T…
d6572cc 
…REAT_WARNING_AS_ERRORS flags
Created one more simple test
463eafa
deleted SYS_vfork references and substituted SYS_open with SYS_openat
8390aad
Correctly patching 490 out of 492 ecall in libc. To do: debug return …
165b36d 
…to libc from asm_template
ECALL can now be successfully patched even with just 6 overwritable b…
db7244f 
…ytes if ISA compressed module is supported. TO DO: more testing
added simple openat interception test
3164838
Commented out useless debug_dump calls
dc0bde7
changed two flags and corrected link_directories
fc2c796
added trampoline creation in 6 byte patch case
eed7bdd
updated .gitignore and one assembly test
8a51ff9
test/CMakeLists.txt test push
2db363e
restored original version of test/CMakeLists.txt
a864c32
@SilenceDesigner
Fixed relocation bug and fixed bug for leaves procedure; now returnin…
76e7e5c 
…g to libc with absolute jump instead of ret
@SilenceDesigner
added some tests
dbb4538
@SilenceDesigner
some more tests
0f6f411
@SilenceDesigner
corrected some more tests
2f88c94
@SilenceDesigner
example.c test corrected
93ec711
@SilenceDesigner
c.nop placement bug solved
8962c5c
@GlassOfWhiskey
Cleaning arch-specific dependencies
3e7d0e5
@SilenceDesigner
temporary registers are now saved and restored as expected by libc
2fa201b
SilenceDesigner and others added 26 commits July 16, 2025 01:01
@SilenceDesigner
excluded generic test generated files and directories
185d3f7
Updated tests description
f38bb29
removed lines added by github merge
732fc31
poll and ppoll test logging fine-tuning
fb6c8fd
faccessat test logging fixed
8e54554
dup2/dup3 logging test discrepancy solved
107221f
replaced token with where just letters can be present
eb3713c
revert token substitution
77fd75a
Created different log match files for each arch
489606b
Fine-tuned riscv syscall format logging match file
10755aa
create_module format declaration is now optional
51e070c
typo fix
cafd156
fixed accpt4 expetations
15a38d8
fixed accept4 expectations
8bcc45e
typo fix
3a369aa
typo fix
5ac4f55
@SilenceDesigner
Full test suite passed with glibc 2.39 on x64
c1f160c
@SilenceDesigner
Updated riscv syscall_format_log match file
df43ff0
@SilenceDesigner
typo fix
ea36858
@SilenceDesigner
Fixed semctl args expectations
962291d
@SilenceDesigner
typo fix
d5d316b
@SilenceDesigner
fixed renameat2 log expectations
170fd6c
@SilenceDesigner
fixed renameat2 log expectations
09c0637
@SilenceDesigner
added delete_module and quotactl to log match file
132ae5d
@SilenceDesigner
fixed epoll_create log expectation
cfece63
@SilenceDesigner
fixed inotify_init log expectation
9271486
@SilenceDesigner
Copy link
Collaborator Author

SilenceDesigner commented Jul 20, 2025

  • One single fully passed test suite running on both x86_64 and RISC-V. Tests are included in the suite depending on the CPU ISA
  • Tested glibc versions: x86_64 2.35 and 2.39; RISC-V 2.35

GlassOfWhiskey
GlassOfWhiskey approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@GlassOfWhiskey GlassOfWhiskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GlassOfWhiskey GlassOfWhiskey merged commit b05ff80 into master Jul 22, 2025
1 check passed
@GlassOfWhiskey GlassOfWhiskey deleted the riscv-dev branch July 22, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GlassOfWhiskey GlassOfWhiskey GlassOfWhiskey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SilenceDesigner @GlassOfWhiskey @marcoSanti