Bump actions/checkout from 4 to 5#1
Closed
dependabot[bot] wants to merge 43 commits into
Closed
Conversation
With ESLint and Stylelint We: - add the "standard" and "prettier" plugins for ESLint - convert Whitehall's `.eslintrc.js` to the new `eslint.config.js` format Run `yarn install` and then `yarn run lint`
Mainly headings for content to be supplied later.
We add a lint.rake task which is called from our default `Rakefile`. This task runs: - `rubocop` linting on Ruby files - `erb_lint` on ERB templates - JS and SCSS linting via our `yarn run lint` script We'll add a `test` task to this default `rake` task next -- to run our Minitest files.
Recreate a number of elements from Whitehall to demonstrate that layout, publishing-components and asset handling is working: - sass processing with dart - sprockets to compile JS - "design system" layout - header partial - navigation and sub navigation (with sub_navigation component) - 'domain-config.js' to define `GOVUK` global var - asset config in `environments/development.rb`
Now that the asset pipeline is configured properly the default rake task's first dependant task (`lint`) runs without error and we can add the `test` dependency. i.e. now when we run `rake`: - all files are linted - all tests are run
These gems are all used by the existing Content Block Manager code being ported over from Whitehall. General: - babosa: slug creation - content_block_tools: shared library for presenting the content blocks authored here - friendly_id: permalinks - kaminari: pagination - record_tag_helper: adds html container wrapping to ActionView - transitions: state machine - view_component Error handling / debugging in development: - better_errors - binding_of_caller General testing: - database_cleaner-active_record - factory_bot - mocha - webmock Cucumber testing: - capybara - capybara-playwright-driver - cucumber - cucumber-rails - launchy
This commit sets up cucumber testing and brings in a single "feature" initially "Create 'Contact' object". This is probably the most complex test we have so will allow us to drive out the maximum amount of complexity in a single "outside -> in" process. By this we mean running the highest level test and then filling in lower level tests and implementation.
Now that these classes have been extracted from their previous home within an "engine" in Whitehall, they no longer need to live in the `ContentBlockManager::ContentBlock` namespace. We can refactor that later on to make the code less verbose and more readable.
- users (User) - organisations (Organisation) - content_block_documents (Document) - content_block_editions (Edition) We also seed an initial user record, as is done in Whitehall.
This is needed for our JS cucumber tests
For permalinks, I believe...
1. include RecordTagHelper, used to create wrapper elements in markup 2. copy over the `get_content_id(edition)` method used in layout template
Over here it doesn't live in the admin namespace/directory.
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
edavey
force-pushed
the
main
branch
3 times, most recently
from
c687e24 to
94d3b2f
Compare
Contributor
Author
|
Looks like actions/checkout is up-to-date now, so this is no longer needed. |
dependabot
Bot
deleted the
dependabot/github_actions/actions/checkout-5
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/checkout from 4 to 5.
Release notes
Sourced from actions/checkout's releases.
... (truncated)
Changelog
Sourced from actions/checkout's changelog.
... (truncated)
Commits
08c6903Prepare v5.0.0 release (#2238)9f26565Update actions checkout to use node 24 (#2226)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)