(CM-930) Add a prototype for a snippets view#617
Draft
pezholio wants to merge 15 commits into
Draft
Conversation
pezholio
force-pushed
the
CM-930-add-a-prototype-for-a-snippets-view
branch
3 times, most recently
from
cc67db4 to
366f5f4
Compare
This fetches embeds, and returns the surrounding HTML to present the blocks within their context
This will make building URLs easier
We default to snippets, but allow the user to see the full preview
For now, let’s disable the feature flag, so the current tests pass. We’ll add more in-depth testing later.
pezholio
force-pushed
the
CM-930-add-a-prototype-for-a-snippets-view
branch
from
366f5f4 to
71f0f33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a prototype view of what a "snippet-based" preview would look like when previewing a document. This finds where blocks are embedded on a page
(note: doesn't yet support multi-page documents)and shows the block together with some surrounding elements as "snippets".This allows the reviewer to concentrate on the changes that the block is making to the page, rather than the page in its totality. There is also an option to show the whole page preview too.
Screenshot
This is not yet ready for merge, but I will deploy it to integration to demo to the wider team.