This repository was archived by the owner on Oct 27, 2025. It is now read-only.
Inline markdown-toolbar-element (WHIT-2020)#3310
Closed
ChrisBAshton wants to merge 2 commits intomainfrom
Closed
Conversation
markdown-toolbar-element is only used by Content Publisher and Collections Publisher. Content Publisher is due for imminent retirement, at which point it will only be being used by Collections Publisher. We're therefore inlining the module in these publishing apps, so that we can retire the repo and have one less component to maintain. We're only copying over the required compiled JS for Content Publisher, as it's being retired soon - so there's little value in copying over the source code, tests etc. JIRA: https://gov-uk.atlassian.net/browse/WHIT-2020
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Contributor
Author
|
Actually, let's just continue to pull the module from NPM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
markdown-toolbar-element is only used by Content Publisher and
Collections Publisher. Content Publisher is due for imminent
retirement, at which point it will only be being used by
Collections Publisher. We're therefore inlining the module in
these publishing apps, so that we can retire the repo and have
one less component to maintain.
We're only copying over the required compiled JS for Content
Publisher, as it's being retired soon - so there's little value
in copying over the source code, tests etc.
JIRA: https://gov-uk.atlassian.net/browse/WHIT-2020
Follow these steps if you are doing a Rails upgrade.