DGUK-290 Remove generated views by markdown #1843
Merged
Conversation
Obsiye
changed the title
Obsiye
changed the title
Obsiye
force-pushed
the
DGUK-290-move-markdown-render-to-docker-test
branch
from
fad5085 to
0a804a1
Compare
Obsiye
changed the title
Obsiye
force-pushed
the
DGUK-290-move-markdown-render-to-docker-test
branch
from
58eefbd to
90dc23e
Compare
ashimali
approved these changes
Apr 1, 2026
Contributor
ashimali
left a comment
ashimali
left a comment
There was a problem hiding this comment.
I would just add a bit of clarification to readme about requirement of local rendering.
I know we may move soon and we might all know this but in case another dev wanted to checkout and see things working as they should, then I think useful for the readme to be clear on that point.
Obsiye
force-pushed
the
DGUK-290-move-markdown-render-to-docker-test
branch
5 times, most recently
from
8fafb04 to
ace4bae
Compare
Obsiye
changed the title
Obsiye
force-pushed
the
DGUK-290-move-markdown-render-to-docker-test
branch
from
33e14e2 to
3d31733
Compare
Run markdown render before test suite update tests
Fix typos Undo refactor as it's out of scope for this ticket
Set the markdown render to run after the precompile assetes in the docker files. This makes sure that some of the image assets are available as they're required for the views outputted by the markdown render rake task. Fix collection image path Fix tests
Run markdown render in spec/rails_helper. This is because feature tests require the app/views/generated views to exist. Refactor markdown to be more resilliant to failures Add tests
Obsiye
force-pushed
the
DGUK-290-move-markdown-render-to-docker-test
branch
from
be2957c to
27584d7
Compare
ashimali
approved these changes
Apr 10, 2026
ashimali
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.