DGUK-290 fix flaky tests#1856
Closed
Obsiye wants to merge 1 commit intoDGUK-290-move-markdown-render-to-docker-testfrom
Closed
DGUK-290 fix flaky tests#1856Obsiye wants to merge 1 commit intoDGUK-290-move-markdown-render-to-docker-testfrom
Obsiye wants to merge 1 commit intoDGUK-290-move-markdown-render-to-docker-testfrom
Conversation
Run markdown render in spec/rails_helper. This is because feature tests require the app/views/generated views to exist. Refactor markdown to be more resilliant to failures Add tests
Obsiye
force-pushed
the
DGUK-290-fix-flaky-tests
branch
from
8f89f19 to
cd90b05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After removing the markdown rendered, generated/views, flaky tests appeared.
This should hopefully resolve those.