Skip to content

Csv content update #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Csv content update #1963

wants to merge 2 commits into from

Conversation

william-castoncook
Copy link
Contributor

@william-castoncook william-castoncook commented May 16, 2025

What problem does this pull request solve?

Trello card: https://trello.com/c/UKDr1rZc/2196-tweak-content-to-get-completed-forms-as-csv-files-page-and-any-other-pages-to-mention-csv-as-attachment

Updated content to reference CSV file attachments

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

Updated content about CSV file attachments
Updated CSV file attachment content
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-1963.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

Copy link
Contributor

@hannahkc hannahkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - one change missed that I've added as a suggestion.

A tech person will need to review too before we merge.

@@ -344,7 +344,7 @@ en:

<p>If you wish, you can also get the answers in a comma-separated values (CSV) file. A CSV lists all the answers in plain text, separated by commas. It can be easier to copy and paste, or import into spreadsheets or other applications.</p>

<p>If you select this option, a link to a CSV file will be added to each completed form email.</p>
<p>If you select this option, a CSV file will be added to each completed form email.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>If you select this option, a CSV file will be added to each completed form email.</p>
<p>If you select this option, a CSV file will be attached to each completed form email.</p>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants