Do not cache S3 ls results#22
Merged
Merged
Conversation
fsspec was caching the results of the `ls` operation when loading the list of available visualisations. This means that a user visiting the `/visualisations` page would not see the latest list of results. Update the usage of fsspsec so that the results are loaded fresh each time. In a heavily used app, the caching could be useful, but during this proof-of-concept work it is not necessary and makes the app frustrating to use.
daymohlar
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fsspec was caching the results of the
lsoperation when loading the list of available visualisations. This means that a user visiting the/visualisationspage would not see the latest list of results. Update the usage of fsspsec so that the results are loaded fresh each time.In a heavily used app, the caching could be useful, but during this proof-of-concept work it is not necessary and makes the app frustrating to use.
Jira ticket