Skip to content

Acw 88/excluding aliases with zero occurences#51

Merged
daymohlar merged 4 commits into
mainfrom
ACW-88/excluding-aliases-with-zero-occurences
May 21, 2026
Merged

Acw 88/excluding aliases with zero occurences#51
daymohlar merged 4 commits into
mainfrom
ACW-88/excluding-aliases-with-zero-occurences

Conversation

@daymohlar
Copy link
Copy Markdown
Contributor

This PR changes includes the following

  • Excluding aliases with zero occurrences
  • Modifying z-score to ensure these aliases are excluded.

Ademola Adefioye added 4 commits May 21, 2026 12:03
This PR includes the following changes
* Removes aliases that have no occurences
* Ensures that aliases excluded are not included as part of the metrics
calculations
Updating test modules
Copy link
Copy Markdown
Contributor

@rjsteixeira rjsteixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comment about us lowercasing & splitting everything. Should we use a more specific regex or do we just not touch them?

Also, not sure if we are de-dupping for alias with the same name.

Comment thread src/models/graph_models.py
@daymohlar daymohlar merged commit 8301b5d into main May 21, 2026
2 checks passed
@daymohlar daymohlar deleted the ACW-88/excluding-aliases-with-zero-occurences branch May 21, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants