Add sidekiq concurrency setting for Heroku review apps#623
Merged
Conversation
A while ago, we added separate processes for answer generation and other async tasks in Sidekiq. However, we didn't set the concurrency for Sidekiq in our Heroku review apps. This means that the default concurrency of 10 is used, which exceeds the db conns we have available on Heroku's basic plan. This commit adds a SIDEKIQ_CONCURRENCY setting to app.json, setting it to 5, which will keep the number of db connections within the basic plan limits.
davidgisbey
force-pushed
the
set-sidekiq-concurrency-on-heroku-review-apps
branch
from
62a99a1 to
c77b68e
Compare
kevindew
approved these changes
Nov 6, 2025
Member
kevindew
left a comment
kevindew
left a comment
There was a problem hiding this comment.
@davidgisbey is this still something we should do? If so I've approved it as it still sounds reasonable
Contributor
Author
|
It is. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A while ago, we added separate processes for answer generation and other async tasks in Sidekiq. However, we didn't set the concurrency for Sidekiq in our Heroku review apps. This means that the default concurrency of 10 is used, which exceeds the db conns we have available on Heroku's basic plan.
This commit adds a SIDEKIQ_CONCURRENCY setting to app.json, setting it to 5, which will keep the number of db connections within the basic plan limits.