Update metrics to take answer model as argument#749
Merged
Conversation
When I added the EvaluateAnswerFromQuestionMessage class, I made a faulty assumption that the metric inputs would be a question and answer message. However, the remaining two metrics take an answer message and used sources. This commit updates the AnswerRelevancy and Coherence metrics to take the answer model as an argument. The class then decides what it wants to do with it, allowing us more flexibility. I've updated the EvaluateAnswerFromQuestionMessage class to reflect this change by calling the evaluation class with the answer.
davidgisbey
force-pushed
the
update-metrics-to-take-answer-model
branch
from
c619449 to
1d1f131
Compare
jackbot
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When I added the EvaluateAnswerFromQuestionMessage class, I made a faulty assumption that the metric inputs would always be a question and answer message.
However, the remaining two metrics take an answer message and used sources. This commit updates the AnswerRelevancy and Coherence metrics to take the answer model as an argument. The class then decides what it wants to do with it, allowing us more flexibility.
I've updated the EvaluateAnswerFromQuestionMessage class to reflect this change by calling the evaluation class with the answer.
Trello card
https://trello.com/c/cUIagBUx/2996-ruby-auto-eval-for-coherence-metric