Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions app/jobs/answer_analysis_job.rb

This file was deleted.

5 changes: 1 addition & 4 deletions app/jobs/compose_answer_job.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ def perform(question_id)
logger.warn("Already an answer created for #{question_id}")
end

if answer.persisted?
AnswerAnalysisJob.perform_later(answer.id)

end
AnswerAnalysis.enqueue_async_analysis(answer) if answer.persisted?
end
end
6 changes: 6 additions & 0 deletions lib/answer_analysis.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
module AnswerAnalysis
def self.enqueue_async_analysis(answer)
TagTopicsJob.perform_later(answer.id)
AnswerRelevancyJob.perform_later(answer.id)
end
end
18 changes: 0 additions & 18 deletions spec/jobs/answer_analysis_job_spec.rb

This file was deleted.

5 changes: 2 additions & 3 deletions spec/jobs/compose_answer_job_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

before do
allow(AnswerComposition::Composer).to receive(:call).and_return(returned_answer)
allow(AnswerAnalysisJob).to receive(:perform_later)
end

it_behaves_like "a job in queue", "answer"
Expand All @@ -17,9 +16,9 @@
.and change(AnswerSource, :count).by(2)
end

it "calls the AnswerAnalysisJob with the answer id" do
it "enqueues the answer analysis jobs" do
expect(AnswerAnalysis).to receive(:enqueue_async_analysis).with(returned_answer)
described_class.new.perform(question.id)
expect(AnswerAnalysisJob).to have_received(:perform_later).with(returned_answer.id)
end

context "when the question has already been answered" do
Expand Down
10 changes: 10 additions & 0 deletions spec/lib/answer_analysis_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
RSpec.describe AnswerAnalysis do
describe ".enqueue_async_analysis" do
it "enqueues the analysis jobs" do
answer = build(:answer)
expect(described_class::TagTopicsJob).to receive(:perform_later).with(answer.id)
expect(described_class::AnswerRelevancyJob).to receive(:perform_later).with(answer.id)
described_class.enqueue_async_analysis(answer)
end
end
end