WIP: Add links to rebranded code examples#4630
Closed
domoscargin wants to merge 8 commits into
Closed
Conversation
There's still some repeated content in the branding wording which might be able to be made reusable
This was
linked to
issues
Apr 14, 2025
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
fdf48ce to
611a42d
Compare
611a42d to
95e67c8
Compare
98cafea to
362edcc
Compare
This was
unlinked from
issues
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adding a
rebrand: truefrontmatter property to any code example will (during build):index.njktobranded.njkbranded/subdirectory, to take advantage of{% set govukRebrand = true %}(potentially this could be automated as well, so we don't need to manually duplicate/maintain the layout files either)rebrand: trueintogovukHeaderandgovukFootermacro calls[type]/[title]/[example]/branded/index.html(eg:components/header/default/branded/index.html)To do
Future
It should be relatively easy to swap all the "branded", "rebrand" naming for something like "legacy" or whatever we want to call our current styles when we eventually default to the rebrand styles.