-
Notifications
You must be signed in to change notification settings - Fork 268
Improve the title and findability of the contact page #5068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify project configuration. |
selfthinker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good.
I find it interesting how often link texts to this page already say "contact the Design System team", which strengthens our decision to change the title to that.
I will not approve yet due to the outstanding decision to potentially change the new URL to something else. I will approve after that was done.
.github/ISSUE_TEMPLATE/config.yml
Outdated
| contact_links: | ||
| - name: Get in touch another way | ||
| url: https://design-system.service.gov.uk/get-in-touch/ | ||
| url: https://design-system.service.gov.uk/contact-the-design-system-team/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file made me think that this probably also exists in govuk-frontend, and it does. I don't think it's too important to adjust URLs elsewhere because of the redirect, but there are a few instances in the other repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And there are more across alphagov.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good spot! Once this is merged I'll do some cleanup in our repos first and then target the others
5c5ec07 to
f192e19
Compare
selfthinker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. 👍
What
Does 2 things:
Why
Addresses a number of informed hypotheses on the contact page:
Done as part of https://github.com/alphagov/design-system-team-internal/issues/1118 but doesn't solve it as we have more content work to do for this.