Adjust new file upload guidance for Dragon users #5073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify project configuration. |
src/components/file-upload/index.md
Outdated
| With the improved File upload component, users can say commands for interacting with web page controls to choose files. | ||
|
|
||
| However, due to [browser security features](https://developer.mozilla.org/en-US/docs/Web/Security/User_activation), this may not work on subsequent interactions on the same page. If the component needs to be used more than once (for example, to correct a mistake), users will first need to perform another action, such as a mouse click. | ||
| However, due to [browser security features](https://developer.mozilla.org/en-US/docs/Web/Security/User_activation), this may not work immediately or on subsequent interactions on the same page. If users cannot interact with the component, they will first need to perform another action, such as a mouse click. |
Contributor
There was a problem hiding this comment.
Suggested change
| However, due to [browser security features](https://developer.mozilla.org/en-US/docs/Web/Security/User_activation), this may not work immediately or on subsequent interactions on the same page. If users cannot interact with the component, they will first need to perform another action, such as a mouse click. | |
| However, due to [browser security features](https://developer.mozilla.org/en-US/docs/Web/Security/User_activation), this may not work right away or on subsequent interactions on the same page. If users cannot interact with the component, they'll first need to perform another action, such as a mouse click. |
Contributor
Author
There was a problem hiding this comment.
Thanks, I've made those changes and pushed.
Contributor
calvin-lau-sig7
left a comment
calvin-lau-sig7
left a comment
There was a problem hiding this comment.
Makes sense! How do these suggestions look to make it a bit more readable?
We learned that sometimes a Dragon command works the first time, and sometimes it doesn't. This changes the text to work for both scenarios.
selfthinker
force-pushed
the
update-file-upload-dragon-guidance
branch
from
2c26914 to
51553f9
Compare
calvin-lau-sig7
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We learned that sometimes a Dragon command for using the file upload component works the first time, and sometimes it doesn't. This changes the guidance text to work for both scenarios.
For more context:
Someone from the NHS Design System contacted us that when they test the new file upload component with Dragon they cannot interact with it at all before performing another action. In our testing the first time always worked. As user activation is supposed to need another action after a page load, we assume that there is a bug somewhere on our side (probably in the Chrome browser).
The fact is that our testing results are different means we are keeping the language of "may" as different versions of Dragon/Chrome/Windows behave inconsistently.