Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misformatted codeblock in install-with-npm page #506

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

romaricpascal
Copy link
Member

@romaricpascal romaricpascal commented Mar 11, 2025

The intentation was making Markdown consider the fenced block part of the content rather than the start of the code block and rendering the following on the page:

```scss
@import "node_modules/govuk-frontend/dist/govuk/index";
```

It now correctly renders:

@import "node_modules/govuk-frontend/dist/govuk/index";

Before: https://frontend.design-system.service.gov.uk/installing-with-npm/#get-the-css-assets-and-javascript-working
After: https://deploy-preview-506--govuk-frontend-docs-preview.netlify.app/installing-with-npm/#get-the-css-working

Fixes #505

The intentation was making Markdown consider the fenced block part of the content rather than the start of the code block
Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for govuk-frontend-docs-preview ready!

Name Link
🔨 Latest commit 02f5c10
🔍 Latest deploy log https://app.netlify.com/sites/govuk-frontend-docs-preview/deploys/67d074b3d9cf210008addc17
😎 Deploy Preview https://deploy-preview-506--govuk-frontend-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@romaricpascal romaricpascal merged commit dba96e0 into main Mar 11, 2025
5 checks passed
@romaricpascal romaricpascal deleted the installing-with-npm-codeblock branch March 11, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation - scss sample code not rendered correctly
2 participants