Remove trailing /index of @import statements in v6.0.0 docs#601
Merged
Conversation
v6.0.0 only supports Dart Sass 1.79+, which will automatically loads the `index.scss` or `_index.scss` files if the path resolves to a folder. Only the content of the v6.0.0 docs has been updated, as v5.0.0 and v4.0.0 still support Ruby Sass and LibSass which would need the full path to the imported file.
✅ Deploy Preview for govuk-frontend-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
domoscargin
approved these changes
Feb 23, 2026
Contributor
There was a problem hiding this comment.
Just a note that we should also be doing something about our components def in PackageContents at some point.
Currently it's matching anything between @import and /index, so I guess its probably something to change when we actually install a version of govuk-frontend that doesn't include those /index strings.
The actual changes here look good though!
Member
Author
Yeah, noted that on Slack on Friday. I think it's part of an issue to remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v6.0.0 only supports Dart Sass 1.79+, which will automatically loads the
index.scssor_index.scssfiles if the path resolves to a folder.Only the content of the v6.0.0 docs has been updated, as v5.0.0 and v4.0.0 still support Ruby Sass and LibSass which would need the full path to the imported file.
Fixes #600