Fix broken list in ‘Install with npm’ instructions#605
Merged
Conversation
The extra line break causes the markdown parser to treat the lines starting with dashes as a separate list, rather than a nested list under the first numbered bullet, so we end up with: 1. Copy the following 3 items: - /node_modules/govuk-frontend/dist/govuk/assets/images folder to <YOUR-APP>/assets/images - /node_modules/govuk-frontend/dist/govuk/assets/fonts folder to <YOUR-APP>/assets/fonts - /node_modules/govuk-frontend/dist/govuk/assets/manifest.json file to <YOUR-APP>/assets 1. Run your application, then use the Fonts tab in Firefox Page Inspector to check the accordion is using the GDS Transport font. Remove the extra line break to fix the nested list. Make the same change to the v5 docs, where the same issue occurs. (The v4 docs do not include this guidance)
✅ Deploy Preview for govuk-frontend-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extra line break causes the markdown parser to treat the lines starting with dashes as a separate list, rather than a nested list under the first numbered bullet, so we end up with:
Remove the extra line break to fix the nested list, like so:
Make the same change to the v5 docs, where the same issue occurs. (The v4 docs do not include this guidance)