Fix contrast issues with comments in code examples#621
Merged
Conversation
The colours were updated to better match version 6 but for comments they were mistakenly set to the wrong colour. This results in comments that are very hard to read. I have put in a quick patch here to resolve the issue immediately and will upstream this patch into the tech-docs-gem. alphagov/tech-docs-gem@f09a4b8#diff-81435f36c443c406a3436b0531a4991cd20655917ede750cec10d5b2c6b3bdcf
✅ Deploy Preview for govuk-frontend-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
domoscargin
approved these changes
Apr 28, 2026
Contributor
domoscargin
left a comment
domoscargin
left a comment
There was a problem hiding this comment.
Looks good - can we add an issue to remove this fix when we bump tech docs?
Contributor
Author
|
Will do thank you! |
Contributor
Author
|
Ah already raised: |
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The colours were updated to better match version 6 but for comments they were mistakenly set to the wrong colour.
This results in comments that are very hard to read.
I have put in a quick patch here to resolve the issue immediately and will upstream this patch into the tech-docs-gem.
Screenshots
Before
After