[SPIKE] Sass module @import backwards compatibility#5983
Open
colinrotherham wants to merge 9 commits intoalphagov:mainfrom
Open
[SPIKE] Sass module @import backwards compatibility#5983colinrotherham wants to merge 9 commits intoalphagov:mainfrom
@import backwards compatibility#5983colinrotherham wants to merge 9 commits intoalphagov:mainfrom
Conversation
@import backwards compatibility@import backwards compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spike to support Sass module
@forward/@usebut keep@importfor nowNot for consideration, only for research into #5981 and comes in two parts:
@importbackwards compatibility #5983 (this PR)Optional imports restored
This PR mostly removes the workarounds necessary to resolve:
As predicted previously in #1671 (comment)
Why Sass modules?
It lets the compiler find issues that previously needed tests
For example:
%govuk-listplaceholder from other partial_or$_need renaming for public use in other partialsmq()which breaks unlesssass-mqhas@forward$sass-mq-already-includeddoes not work (but can be fixed)$govuk-font-url-functionvalue does not work due to scope$govuk-image-url-functionvalue does not work due to scopeThis PR takes all the fixes from #5982 and turns them back into
@importfor backwards compatibilityIt allows service teams to use Sass modules until #1791 can be picked up