Allow component examples to define custom supporting HTML for tests (fixes #6702 )#6713
Open
moshaid wants to merge 8 commits intoalphagov:mainfrom
Open
Allow component examples to define custom supporting HTML for tests (fixes #6702 )#6713moshaid wants to merge 8 commits intoalphagov:mainfrom
moshaid wants to merge 8 commits intoalphagov:mainfrom
Conversation
moshaid
force-pushed
the
HTML-Component
branch
from
5bd73ad to
9bc5e9b
Compare
Resolved conflict in components.template.test.js by keeping the data-driven supportingHTML field approach and removing hardcoded conditional logic. This maintains the solution that meets the 'Done when' criteria of not defining markup in the test file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the small story on #6702
What Changed
Removed hardcoded markup from "components.template.test.js" and added a supportingHTML field so examples can declare their own supporting HTML.
Changes