Skip to content

Add interruption panel - make sure Panel print styles apply to modifiers#7240

Merged
NickColley merged 1 commit into
add-interruption-panel--localfrom
add-interruption-panel--print-mode
Jul 2, 2026
Merged

Add interruption panel - make sure Panel print styles apply to modifiers#7240
NickColley merged 1 commit into
add-interruption-panel--localfrom
add-interruption-panel--print-mode

Conversation

@NickColley

@NickColley NickColley commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Note

A final review will be available once we get the contribution branch ready
I will manually merge this into #6636 once approved since we cant merge into a external repo via GitHub

Move to below the modifiers for Confirmation and Interruption so that the print styles have higher precedence.

Screenshot of Confirmation and Interruption Panel variants in print render mode

Screenshot showing panel component in print mode

Note that there are issues with the button in print mode but this is unrelated to the Panel so should be considered separately.

Move to below the modifiers for Confirmation and Interruption
so that the print styles have higher precedence.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-7240 July 2, 2026 14:09 Inactive
@NickColley NickColley changed the title Make sure Panel print styles apply to modifiers Add interruption panel - make sure Panel print styles apply to modifiers Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Stylesheets changes to npm package

diff --git a/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css b/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css
index 93d224815..9e949019e 100644
--- a/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css
+++ b/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css
@@ -4255,14 +4255,6 @@ screen and (forced-colors:active) {
     }
 }
 
-@media print {
-    .govuk-panel {
-        --govuk-text-colour: inherit;
-        border-color: currentcolor;
-        background: none
-    }
-}
-
 .govuk-panel__title {
     font-size: 2rem;
     line-height: 1.09375;
@@ -4303,6 +4295,14 @@ screen and (forced-colors:active) {
     text-align: left
 }
 
+@media print {
+    .govuk-panel {
+        --govuk-text-colour: inherit;
+        border-color: currentcolor;
+        background: none
+    }
+}
+
 @media (min-width:20em) {
     .govuk-password-input__wrapper {
         flex-direction: row;

Action run for 73ee614

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Other changes to npm package

diff --git a/packages/govuk-frontend/dist/govuk/components/panel/_mixin.scss b/packages/govuk-frontend/dist/govuk/components/panel/_mixin.scss
index a91cca73b..9b095e041 100644
--- a/packages/govuk-frontend/dist/govuk/components/panel/_mixin.scss
+++ b/packages/govuk-frontend/dist/govuk/components/panel/_mixin.scss
@@ -34,12 +34,6 @@
       // it but the the text remains legible.
       overflow-wrap: break-word;
     }
-
-    @media print {
-      --govuk-text-colour: inherit;
-      border-color: currentcolor;
-      background: none;
-    }
   }
 
   .govuk-panel__title {
@@ -63,5 +57,13 @@
     background: base.govuk-functional-colour(brand);
     text-align: left;
   }
+
+  @media print {
+    .govuk-panel {
+      --govuk-text-colour: inherit;
+      border-color: currentcolor;
+      background: none;
+    }
+  }
 }
 

Action run for 73ee614

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

📋 Stats

No changes to any distributed file sizes!


Action run for 73ee614

@NickColley NickColley marked this pull request as ready for review July 2, 2026 14:16

@romaricpascal romaricpascal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the job neatly 🥳

@NickColley NickColley merged commit 587f242 into add-interruption-panel--local Jul 2, 2026
49 checks passed
@NickColley NickColley deleted the add-interruption-panel--print-mode branch July 2, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants