Add Feedback as a template block#7248
Closed
owenatgov wants to merge 1 commit into
Closed
Conversation
owenatgov
force-pushed
the
feedback-template-block
branch
from
e20ae5e to
e0f71b7
Compare
2 tasks
📋 StatsNo changes to any distributed file sizes! Action run for e0f71b7 |
Contributor
Author
|
We've decided we won't do this for MVP of the component as users can still add the component to their template with minimal hassle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
govukFeedbackblock to the page template as well as 2 extra template variables:feedbackBodywhich, when set, displays FeedbackfeedbackTitlewhich is preset but can be overriddenResolves #7234
Stacked on top of #7232
Notes
Interested in opinions on presetting
feedbackTitle. For this particular component we have quite a clear default we want users to apply and users can reset it anyway.I've attempted to combine the changelog entries for this and the PR adding the actual component into a single entry. Interested especially in @seaemsi's opinion on this.
Do we also need changelog entries for
feedbackBodyandfeedbackTitle? Could they go into this entry?