Make file input selector more specific when setting up JavaScript-enhanced file input#7268
Open
peteryates wants to merge 1 commit into
Open
Conversation
Now, instead of finding any input and failing if its type isn't "file", it finds inputs with type "file" and fails if nothing is found. Since version 7.0, when the multiple attribute is set on a file input, Rails also renders a hidden input just before the file input, e.g., <input name="profile[profile_photo][]" type="hidden" value=""> <input id="profile-profile-photo-field" class="govuk-file-upload" multiple="multiple" type="file" name="profile[profile_photo][]"> This ensures that when the user submits a form with no files selected, the form submission includes profile[profile_photo][], and Rails can delete any files that are attached.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, instead of finding any input and failing if its type isn't "file", it finds inputs with type "file" and fails if nothing is found.
Since version 7.0, when the multiple attribute is set on a file input, Rails also renders a hidden input just before the file input, e.g.,
This ensures that when the user submits a form with no files selected, the form submission includes
profile[profile_photo][], and Rails can delete any files that are attached.