✨ Add govuk-reports-prototype chart#3308
Open
jasonBirchall wants to merge 5 commits into
Open
Conversation
added 5 commits
July 4, 2025 15:12
This commit adds the [govuk-reports-prototype](https://github.com/alphagov/govuk-reports-prototype) so we can use integration to host the prototype. This means we can start looking at collaborating on differnt ideas and having a prototype url we can showcase.
While working in this repository, I found that when pushing changes I was failing kubeconform requirements. I wanted to test this locally before pushing, so I've added a make command that lets you either `make lint` and run all the linting locally, or, run `make kubeconform` that performs the kubeconform command for you and outputs the errors locally. This way I was able to quickly identify where the failure was located and fix it. In this instance, it appeared in the rendered deployment.yaml file for reports-prototype.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces updates to the
Makefileto enhance linting capabilities and adds configuration for deploying thegovuk-reports-prototypeapplication in Kubernetes. The most important changes include the addition of the configuration of thegovuk-reports-prototypeapplication to integration.Makefile enhancements:
kubeconformvalidation: Introduced a newkubeconformtarget to validate rendered Kubernetes charts using thekubeconformtool with strict schema checks and custom schema locations. While working in this repository, I found that when pushing changes, I were failing kubeconform requirements. I wanted to test this locally before pushing, so I've added a make command that lets you eithermake lintand run all the linting locally, or, runmake kubeconformthat performs the kubeconform command for you and outputs the errors locally. This way, I was able to identify where the failure was located and fix it quickly. In this instance, it appeared in the rendered deployment.yaml file for reports-prototype.linttarget toyamllint: Thelinttarget was renamed toyamllint, and a newlinttarget was created to run bothyamllintandkubeconform.Kubernetes configuration for
govuk-reports-prototype:govuk-reports-prototypeapplication withimage_tag: v1, enabled automatic deployments, and disabled promotion of deployments.govuk-reports-prototype, including resource limits, ingress settings, service account annotations, health checks, and environment variables for logging and AWS region.