DB Sync App/CronJob Charts#4258
Open
dj-maisy wants to merge 5 commits into
Open
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This creates a new set of Helm charts for the new DB Sync application. The images are still awaiting publish but in theory these charts should work as I've been able to lint and template them locally.
For now, as we only want to "test" the app, there are only configurations set up for "production" to backup. There are separate safety checks in the app to prevent restores happening to production without a confirmation (which is also only possible when running the app interactively).
How to Review?
Maybe this...
...should give you a rendered Template with no errors.
Related