Migrate Pub Infra Attachments Bucket to Module...#4222
Open
dj-maisy wants to merge 6 commits into
Open
Conversation
1 task
...and... * Update module to override object ownership setting * Update any affected modules to prevent false drift
jfharden
force-pushed
the
dj-maisy/3887-migrate-attachments-s3-config
branch
from
ae649c0 to
620909c
Compare
jfharden
force-pushed
the
dj-maisy/3887-migrate-attachments-s3-config
branch
from
7504bc4 to
78eb7db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This migrates the Attachments S3 Terraform to use the standard module, and...
Updates the S3 module to support overriding the object ownership settingEnable object owner enforcement on the bucket and remove it's acl meaning access is now fully controlled by bucket policyThis bucket appears unused now, the only policies I can find have all long been removed, and the number of objects and total size hasn't changed in the full 15 Months of cloudwatch metric histor3
Related