Clean out old imports and moves#4236
Open
AP-Hunt wants to merge 2 commits into
Open
Conversation
All of the remaining import statements are either necessary (e.g. for disaster recovery), or its unclear if they're been applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
We had a bunch of Terraform
import,moved, andremovedblocks in code. After they've been applied, outside of a very few scenarios, they aren't necessary anymore.This PR removes them.
How to review
git grep "import {". Do you agree that what's left are important?git grep "moved {". Find any I missed?