Skip to content

Give JobName in JobRequestStatus struct an accurate description #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nimalank7 merged 1 commit into from
May 20, 2026
+2 −22
Merged

Give JobName in JobRequestStatus struct an accurate description #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions api/v1/jobrequest_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,20 +47,7 @@ type JobRequestSpec struct {

// JobRequestStatus defines the observed state of JobRequest.
type JobRequestStatus struct {
// INSERT ADDITIONAL STATUS FIELD - define observed state of cluster
// Important: Run "make" to regenerate code after modifying this file

// For Kubernetes API conventions, see:
// https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties

// conditions represent the current state of the JobRequest resource.
// Each condition has a unique type and reflects the status of a specific aspect of the resource.
//
// Standard condition types include:
// - "Available": the resource is fully functional
// - "Progressing": the resource is being created or updated
// - "Degraded": the resource failed to reach or maintain its desired state
//
// Name of the Kubernetes Job created for this job request.
JobName string `json:"jobName,omitempty"`
// +kubebuilder:validation:Enum=Requested;Approved;Rejected;Started;Completed;Failed
State string `json:"state,omitempty"`
Expand Down
9 changes: 1 addition & 8 deletions config/crd/bases/platform.publishing.service.gov.uk_jobrequests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,14 +138,7 @@ spec:
description: status defines the observed state of JobRequest
properties:
jobName:
description: |-
conditions represent the current state of the JobRequest resource.
Comment thread
samsimpson1 marked this conversation as resolved.
Each condition has a unique type and reflects the status of a specific aspect of the resource.

Standard condition types include:
- "Available": the resource is fully functional
- "Progressing": the resource is being created or updated
- "Degraded": the resource failed to reach or maintain its desired state
description: Name of the Kubernetes Job created for this job request.
type: string
requestedBy:
description: Kubernetes username of the user who made the job request.
Expand Down