Skip to content

Accessibility: missing role for expandable section #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronfowles merged 1 commit into from
Jan 22, 2026
Merged

Accessibility: missing role for expandable section #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions src/frontend/view/view-search-panel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const viewKeywordSearchPanel = () => `
state.searchResults
? ''
: `<details class="govuk-details" data-module="govuk-details">
<summary class="govuk-details__summary">
<summary class="govuk-details__summary" role="button">
<span class="govuk-details__summary-text">
Search filters
</span>
Expand Down Expand Up @@ -114,10 +114,10 @@ const viewLinkSearchPanel = () => `
state.searchResults
? ''
: `<details class="govuk-details" data-module="govuk-details">
<summary class="govuk-details__summary">
<span class="govuk-details__summary-text">
Search filters
</span>
<summary class="govuk-details__summary" role="button">
<span class="govuk-details__summary-text">
Search filters
</span>
</summary>
<div class="govuk-details__text">
<div class="search-filters-container">
Expand Down Expand Up @@ -187,7 +187,7 @@ const viewTaxonSearchPanel = () => `
state.searchResults
? ''
: `<details class="govuk-details" data-module="govuk-details">
<summary class="govuk-details__summary">
<summary class="govuk-details__summary" role="button">
<span class="govuk-details__summary-text">
Search filters
</span>
Expand Down Expand Up @@ -222,7 +222,7 @@ const viewPersonSearchPanel = () => `
state.searchResults
? ''
: `<details class="govuk-details" data-module="govuk-details">
<summary class="govuk-details__summary">
<summary class="govuk-details__summary" role="button">
<span class="govuk-details__summary-text">
Search filters
</span>
Expand All @@ -237,8 +237,6 @@ const viewPersonSearchPanel = () => `
<div class="search-filters-right-col taxon-search">
${viewDocumentType()}
${viewPublishingAppSelector()}
${viewPoliticalStatusSelector()}
${viewGovernmentSelector()}
</div>
</div>
</div>
Expand All @@ -257,7 +255,7 @@ const viewLanguageSearchPanel = () => `
state.searchResults
? ''
: `<details class="govuk-details" data-module="govuk-details">
<summary class="govuk-details__summary">
<summary class="govuk-details__summary" role="button">
<span class="govuk-details__summary-text">
Search filters
</span>
Expand Down Expand Up @@ -292,7 +290,7 @@ const viewOrganisationSearchPanel = () => `
state.searchResults
? ''
: `<details class="govuk-details" data-module="govuk-details">
<summary class="govuk-details__summary">
<summary class="govuk-details__summary" role="button">
<span class="govuk-details__summary-text">
Search filters
</span>
Expand Down
Loading