Skip to content

ci: explicitly set required permissions on GitHub Actions Workflows#303

Merged
aaronfowles merged 1 commit into
mainfrom
address_codeql_actions_permissions_issue
Sep 22, 2025
Merged

ci: explicitly set required permissions on GitHub Actions Workflows#303
aaronfowles merged 1 commit into
mainfrom
address_codeql_actions_permissions_issue

Conversation

@aaronfowles
Copy link
Copy Markdown
Contributor

@aaronfowles aaronfowles marked this pull request as ready for review September 22, 2025 08:40
@aaronfowles aaronfowles force-pushed the address_codeql_actions_permissions_issue branch from 9009f42 to 406994a Compare September 22, 2025 11:15
The workflows currently have unlimited read/write permissions. This change sets all permissions to contents:read unless explicitly required by a specific action.
Both the actions/create-release@v1 and rickstaa/action-create-tag@v1 actions need to make changes to the repo for release.
Docs showing required permissions for creating releases and tags:
https://docs.github.com/en/rest/authentication/permissions-required-for-github-apps?apiVersion=2022-11-28#repository-permissions-for-contents

This addresses https://github.com/alphagov/govuk-knowledge-graph-search/security/code-scanning/1.
@aaronfowles aaronfowles force-pushed the address_codeql_actions_permissions_issue branch from 406994a to 0d49d92 Compare September 22, 2025 14:51
Copy link
Copy Markdown
Contributor

@JonathanHallam JonathanHallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks :)

@aaronfowles aaronfowles merged commit 0be4362 into main Sep 22, 2025
7 checks passed
@aaronfowles aaronfowles deleted the address_codeql_actions_permissions_issue branch September 22, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants