IA-2688-upgrade-to-node-18#340
Merged
Merged
Conversation
aaronfowles
force-pushed
the
IA-2688-upgrade-google-cloud-biguery-lib
branch
from
e1cf48c to
18947c0
Compare
JonathanHallam
approved these changes
Apr 15, 2026
Contributor
JonathanHallam
left a comment
JonathanHallam
left a comment
There was a problem hiding this comment.
Really good catch. Thanks Aaron :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #333 we checked that the the
google-cloud/bigquerylib upgrade was compatible with node v18 in.nvmrcbut missed the reference in theDockerfile.This PR ensures node is v18 in all places.
This branch is running in dev https://govgraphsearchdev.dev/ and looks fine.