Using internal Govuk Frontend more widely #2317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ard-coded with details from govuk-frontend and aren't particularly useful anymore.
BenSurgisonGDS
approved these changes
Aug 30, 2023
Contributor
BenSurgisonGDS
left a comment
BenSurgisonGDS
left a comment
There was a problem hiding this comment.
I've approved the PR so it can be merged while I'm away, but I have a PR Get scripts and assets from config branched from yours that removes the hard coded locations for the assets and scripts.
This was referenced Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with the preparation for Frontend v5.
Management and internal pages are now properly isolated:
These pages now fully use the version of Govuk Frontend specified in our package.json regardless of which version the user has installed.
I've also removed the plugin sanity checks - they predated our cypress tests, are hard-coded with details from govuk-frontend and aren't particularly useful anymore.