Conversation
AshGDS
changed the title
nnagewad
reviewed
Feb 20, 2026
nnagewad
left a comment
nnagewad
left a comment
There was a problem hiding this comment.
This looks great on mobile. What does it look like on Desktop?
Contributor
Author
|
@nnagewad There should be no visual changes, as the CSS change doesn't affect any of those styles 👍 |
andysellick
reviewed
Feb 20, 2026
| border-top: 1px solid $govuk-border-colour; | ||
|
|
||
| @include govuk-media-query($until: tablet) { | ||
| max-width: 320px; |
Contributor
There was a problem hiding this comment.
Just to note that when a regular image card is next to a 'large version' on mobile (as happens on organisations pages) the layout looks a little inconsistent, below. What's the reason for restricting it to 320px?
Contributor
Author
There was a problem hiding this comment.
It was mainly to preserve large looking distinctly large in this scenario, and also because full width takes up quite a lot of page height. Happy to change it if you think it shouldn't be like this though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why
large, I've limited the image size to320pxon mobile. When the images are full width they look the same aslargeimage cards at certain widths, and take up quite a bit of height on mobile and hence limiting to320px. Happy to change this if you think it should be something else though.Visual Changes