Skip to content

Add a test-with-docker make task#1283

Open
tombye wants to merge 1 commit intomainfrom
add-test-with-docker-task
Open

Add a test-with-docker make task#1283
tombye wants to merge 1 commit intomainfrom
add-test-with-docker-task

Conversation

@tombye
Copy link
Contributor

@tombye tombye commented Nov 21, 2025

This is a proposal to use the docker image we already generate in make-bootstrap-with-docker as another way to run the tests.

I don't think this is necessarily a better approach than that described in the README but it does provide some consistency with how concourse does it and means the Dockerfile ends up as the one description of how to run the tests.

This is a proposal to use the docker image we
already generate in `make-bootstrap-with-docker`
as another way to run the tests.

I don't think this is necessarily a better
approach than that described in the README but it
does provide some consistency with how concourse
does it and means the Dockerfile ends up as the
one description of how to run the tests.
Copy link
Member

@quis quis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried running make bootstrap-with-docker test-with-docker locally but got a few of these errors
redis.exceptions.ConnectionError: Error 99 connecting to localhost:6999. Cannot assign requested address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants