Open
Conversation
This is a proposal to use the docker image we already generate in `make-bootstrap-with-docker` as another way to run the tests. I don't think this is necessarily a better approach than that described in the README but it does provide some consistency with how concourse does it and means the Dockerfile ends up as the one description of how to run the tests.
quis
reviewed
Feb 17, 2026
Member
quis
left a comment
There was a problem hiding this comment.
I tried running make bootstrap-with-docker test-with-docker locally but got a few of these errors
redis.exceptions.ConnectionError: Error 99 connecting to localhost:6999. Cannot assign requested address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal to use the docker image we already generate in
make-bootstrap-with-dockeras another way to run the tests.I don't think this is necessarily a better approach than that described in the README but it does provide some consistency with how concourse does it and means the Dockerfile ends up as the one description of how to run the tests.