Pp 14390 update csp pay js commons#1402
Merged
Merged
Conversation
iqbalgds
force-pushed
the
PP-14390-update-csp-pay-js-commons
branch
from
7abcc30 to
a6a8c79
Compare
- Clean up files
- Move the `hasSubstr` into the CSP middleware file as that is the only place it is being used.
- Also combine the unit tests into the CSP
middleware test file.
iqbalgds
force-pushed
the
PP-14390-update-csp-pay-js-commons
branch
from
a6a8c79 to
b02fe63
Compare
AbdirizakIdris
approved these changes
Sep 29, 2025
Contributor
AbdirizakIdris
left a comment
AbdirizakIdris
left a comment
There was a problem hiding this comment.
Tests passing now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PP-14390 Fix issues with CSP middleware
hasSubstrinto the CSP middleware file as that is the only place it is being used.middleware test file.