PP-13622 Fix incorrect negation for won disputes in CSV files#3806
Merged
marcotranchino merged 1 commit intoApr 11, 2025
Merged
Conversation
d5d2f28 to
8a8ae29
Compare
SandorArpa
requested changes
Apr 11, 2025
8a8ae29 to
fedc4b0
Compare
With this change, we are fixing a bug for which disputed amounts are shown as negative numbers in the CSV files. The logic will now consider also the state of the dispute and present the value as positive when the dispute has been won by the service. Further information in Jira. https://payments-platform.atlassian.net/browse/PP-13622
fedc4b0 to
d509e4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, we are fixing a bug for which disputed amounts are shown as negative numbers in the CSV files.
The logic will now consider also the state of the dispute and present the value as positive when the dispute has been won by the service.
Further information in Jira.
https://payments-platform.atlassian.net/browse/PP-13622