Skip to content

PP-13622 Fix incorrect negation for won disputes in CSV files#3806

Merged
marcotranchino merged 1 commit into
masterfrom
PP-13622-fix-incorrect-amount-in-won-disputes
Apr 11, 2025
Merged

PP-13622 Fix incorrect negation for won disputes in CSV files#3806
marcotranchino merged 1 commit into
masterfrom
PP-13622-fix-incorrect-amount-in-won-disputes

Conversation

@marcotranchino
Copy link
Copy Markdown
Contributor

With this change, we are fixing a bug for which disputed amounts are shown as negative numbers in the CSV files.

The logic will now consider also the state of the dispute and present the value as positive when the dispute has been won by the service.

Further information in Jira.

https://payments-platform.atlassian.net/browse/PP-13622

@marcotranchino marcotranchino force-pushed the PP-13622-fix-incorrect-amount-in-won-disputes branch from d5d2f28 to 8a8ae29 Compare April 11, 2025 09:25
Comment thread src/main/java/uk/gov/pay/ledger/transaction/model/CsvTransactionFactory.java Outdated
@marcotranchino marcotranchino force-pushed the PP-13622-fix-incorrect-amount-in-won-disputes branch from 8a8ae29 to fedc4b0 Compare April 11, 2025 09:54
With this change, we are fixing a bug for which disputed amounts are shown as
negative numbers in the CSV files.

The logic will now consider also the state of the dispute and present the
value as positive when the dispute has been won by the service.

Further information in Jira.

https://payments-platform.atlassian.net/browse/PP-13622
@marcotranchino marcotranchino force-pushed the PP-13622-fix-incorrect-amount-in-won-disputes branch from fedc4b0 to d509e4c Compare April 11, 2025 09:57
Copy link
Copy Markdown
Contributor

@SandorArpa SandorArpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOKTM

@marcotranchino marcotranchino merged commit a19911e into master Apr 11, 2025
10 checks passed
@marcotranchino marcotranchino deleted the PP-13622-fix-incorrect-amount-in-won-disputes branch April 11, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants