Make the metadata block on specialist documents optional #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to add this property to make the metadata block configurable via finder schema. A conditional on the frontend can check for this property to determine whether or not to render the metadata blue box.
GDSNewt
force-pushed
the
toggle-metadata-block-on-specialist-documents
branch
from
030e961 to
fb4c21f
Compare
GDSNewt
force-pushed
the
toggle-metadata-block-on-specialist-documents
branch
from
fb4c21f to
36bfef3
Compare
GDSNewt
force-pushed
the
toggle-metadata-block-on-specialist-documents
branch
from
36bfef3 to
73d930f
Compare
ChrisBAshton
approved these changes
Mar 31, 2025
content_schemas/examples/specialist_document/frontend/countryside-stewardship-grants.json
Show resolved
Hide resolved
Some tests on government frontend use these examples for their rendering tests. I've made drug device alerts and countryside stewardship grants the 'true' cases for rendering the metadata block. Cma cases not having the property is acting as the 'false', i.e do not show the block. We have plans to remove remove all usages of example schema files for Specialist Documents only. It should generate randomly from a schema file, or load from a fixture. The goal is so we can delete the example schema files from Publishing API. Trello backlog ticket(https://trello.com/c/7vhL24Fk/840-update-government-frontend-tests-to-use-randomexample-generation-from-schemas-so-we-can-delete-specialist-document-examples-from)
GDSNewt
force-pushed
the
toggle-metadata-block-on-specialist-documents
branch
from
73d930f to
a3a84bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These change is necessary to make the rendering the blue metadata box at the top of specialist documents dependent on a value defined in the schema of each finder.
Associated PRs
Trello