Make "Read more" link text optional for Topical Event About pages#3860
Draft
ChrisBAshton wants to merge 2 commits intomainfrom
Draft
Make "Read more" link text optional for Topical Event About pages#3860ChrisBAshton wants to merge 2 commits intomainfrom
ChrisBAshton wants to merge 2 commits intomainfrom
Conversation
We're likely to drop this altogether in the move to config-driven topical events.
This is currently done as a link set link ONLY: alphagov/whitehall@e7b8ecb But the StandardEditionPresenter sends links as both link set links and edition links, so we need to change the schema to accommodate edition links for About pages: https://github.com/alphagov/whitehall/blob/2b406d9bb189b7cce7956cb6615aa66c29bad7ed/app/presenters/publishing_api/standard_edition_presenter.rb#L24-L33
ChrisBAshton
force-pushed
the
make-read_more-optional
branch
from
99b126a to
aee55e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're likely to drop this altogether in the move to config-driven topical events.
Needed in conjunction with alphagov/whitehall#11026
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.