(CM-618) Develop smart answers spike #7378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pezholio
force-pushed
the
CM-618-develop-smart-answers-spike
branch
from
8c5f693 to
770a92f
Compare
pezholio
force-pushed
the
CM-618-develop-smart-answers-spike
branch
from
770a92f to
da83bf9
Compare
We’ll need this to fetch content blocks using their embed codes.
pezholio
force-pushed
the
CM-618-develop-smart-answers-spike
branch
from
da83bf9 to
c0d8391
Compare
This uses static analysis of code to fetch all the files associated with a flow, reading the content of those files, and checking if any content blocks embed codes have been used in them. If they have, we return the content blocks in question. I’ve added some YARD-compliant comments to the code, so it’s clear as to what’s going on, as well as made a bunch of methods that would otherwise be considered private to make unit testing easier. In the next commit, we’ll use these to create links when publishing smart answers in Publishing API.
This allows us to send the content IDs of any content blocks that are used in a smart answer as links, so Content Block Manager knows that the blocks are used in a particular Smart Answer.
pezholio
force-pushed
the
CM-618-develop-smart-answers-spike
branch
from
c0d8391 to
595a9e4
Compare
Tetrino
approved these changes
Nov 13, 2025
Contributor
Tetrino
left a comment
Tetrino
left a comment
There was a problem hiding this comment.
Looks good to me! Sensible solution.
I am a little lost on why we need the calculators themselves at this stage but they're not doing any harm and I see there is future relevant functionality in the planning so I'm fine with the references being there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This develops the spike outlined in #7347 to allow us to use Content Blocks within Smart Answers. A lot of the integration with the content blocks has been outsourced to the Content Block Tools Gem, specifically the functionality added in alphagov/govuk_content_block_tools#112.
Most of the actual work in this PR is adding a
ContentBlockDetectorclass which, when a Smart Answer is published to Publishing API, looks to see what content blocks are used in a Smart Answer and publishes the relevant links so they can be shown as related content in Content Block Manager, eg:We currently aren't using any blocks in the code at the moment, but this sets us up so using content blocks is easy and seamless.