Ban pre|post-install NPM scripts#453
Merged
Merged
Conversation
TLDR: they're a common attack vector and blocking them is now the default practice across many teams at GDS. Longer explanation from One Login docs: https://team-manual.account.gov.uk/development-standards-processes/coding-practices-and-processes/configure-node-package-managers/#ignore-scripts
kr8n3r
approved these changes
Mar 27, 2026
This was referenced Mar 30, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What’s changed
These changes block any NPM packages running pre-install or post-install scripts.
Identifying a user need
Pre|post-install scripts are a common attack vector and blocking them like this is now the default practice across many teams at GDS.
Longer explanation from One Login docs:
https://team-manual.account.gov.uk/development-standards-processes/coding-practices-and-processes/configure-node-package-managers/#ignore-scripts
This should also give reviewers of other pull requests that involve the installation of NPM packages more confidence that doing so would not pull in malicious packages.