Skip to content

Skip npm ci call in dependabot bundler job #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JC-DSIT merged 1 commit into from
Apr 22, 2026
Merged

Skip npm ci call in dependabot bundler job #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,10 @@ updates:
interval: "weekly"
day: "monday"
time: "06:00"
env:
DEPENDABOT_JOB: "true"
commit-message:
prefix: chore
# TODO - add labels
# labels:
# - "dependencies"
# - "ruby"
# - "automated-pr"
open-pull-requests-limit: 5

# 2. Update GitHub Actions (keeps your CI workflows secure)
Expand Down
12 changes: 7 additions & 5 deletions govuk_tech_docs.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,12 @@ lib = File.expand_path("lib", __dir__)
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
require "govuk_tech_docs/version"

`npm ci`
abort "npm ci failed" unless $CHILD_STATUS.success?
if ENV["DEPENDABOT_JOB"] == "true" # dependabot will only evaluate the bundler, and will not allow npm
warn "Skipping npm ci due to DEPENDABOT_JOB=true"
else
system("npm ci")
abort "npm ci failed" unless $CHILD_STATUS.success?
end

unless File.exist?("node_modules/govuk-frontend/dist/govuk/_base.scss")
abort "govuk-frontend npm package not installed"
Expand Down Expand Up @@ -45,9 +49,7 @@ Gem::Specification.new do |spec|
spec.add_dependency "middleman-compass"
spec.add_dependency "middleman-livereload"
spec.add_dependency "middleman-search-gds"
=begin
middleman-sprockets is very old and out of date. V4.1.0 has a breaking change. Will look to replace with gem "dartsass-sprockets" or uses sass in the package.json
=end
# middleman-sprockets is very old and out of date. V4.1.0 has a breaking change. Will look to replace with gem "dartsass-sprockets" or uses sass in the package.json
spec.add_dependency "middleman-sprockets", "4.0.0"
spec.add_dependency "middleman-syntax"
spec.add_dependency "mutex_m" # TODO: remove once activesupport declares this itself.
Expand Down
Loading