[PNP-9698] Remove Slimmer from historical editions print view#2398
Merged
Conversation
- The historical edition page and layout was the only thing using the guide-print styles in static (via slimmer), so it's safe to just move it into travel-advice-publisher into the stylesheet included by historical_edition.html.rb, and include the helpers. Audit trail: - https://github.com/alphagov/static/blob/3cfb2352715053aee716ba24f8aa425f94436854/app/assets/stylesheets/helpers/_core-print.scss - https://github.com/alphagov/static/blob/3cfb2352715053aee716ba24f8aa425f94436854/app/assets/stylesheets/helpers/_print-base.scss - https://github.com/alphagov/static/blob/main/app/assets/stylesheets/guides-print.scss
- We don't need slimmer to bring this in, the static template is only used by this app so we can just rewrite the layout to use the information in it. Audit trail: https://github.com/alphagov/static/blob/3cfb2352715053aee716ba24f8aa425f94436854/app/views/root/print.html.erb
KludgeKML
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Travel Advice Publisher uses slimmer/static to provide the print layout and (mainly) the print styles for the historical print view. It's the only thing that uses that static template, so we duplicate the layout information, styles, and single asset into travel advice publisher.
JIRA Card