Remove unused search indexing code [WHIT-1799]#10996
Merged
Merged
Conversation
Organisation indexing is now done via Publishing API.
ryanb-gds
force-pushed
the
remove-unused-search-indexing-code
branch
from
3fbc818 to
b55fc1a
Compare
These pages were not being indexed by Whitehall because the `can_index_in_search?` method was evaluating to false. This was due to topical event about pages being absent from the search API presenter's allowlist. Given nobody seems to have missed them, it seems reasonable to maintain the status quo. We may choose to start indexing them via Publishing API in future, but we don't want to reintroduce the behaviour to Whitehall.
ryanb-gds
force-pushed
the
remove-unused-search-indexing-code
branch
from
b55fc1a to
08a88ed
Compare
ChrisBAshton
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to WHIT-1799
Removes indexing code for both organisations and topical event about pages. The former have been migrated to the 'govuk' index, so are now being indexed via Publishing API, and the latter were not being indexed in the first place.